feat: add custom_supported_browsers to update_passport_config() in ad… #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronAtDuo
reviewed
Feb 28, 2025
AaronAtDuo
requested changes
Feb 28, 2025
Contributor
AaronAtDuo
left a comment
AaronAtDuo
left a comment
There was a problem hiding this comment.
Move away from empty lists as parameter defaults
AaronAtDuo
requested changes
Mar 3, 2025
Contributor
AaronAtDuo
left a comment
AaronAtDuo
left a comment
There was a problem hiding this comment.
One more change please
AaronAtDuo
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom_supported_browsers to update_passport_config() in admin.py
Update update_passport_config method with custom_supported_browsers as a criteria that determines whether a Windows or macOS browsers should be supported by Passport
Description
add custom_supported_browsers as new criteria for update of the current Passport configuration
Motivation and Context
duo_client_python was modified with custom_supported_browsers in https://github.com/cisco-sbg/ZT-trustedpath/pull/23553, so there is a need to have same changes in https://github.com/duosecurity/duo_client_python
How Has This Been Tested?
add test case for custom_supported_browsers in existing test_update_passport test in test_passport.py
Types of Changes